Increase timeouts for macOS toolchain setup #17519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches all macOS toolchain setup compiles and executes to use the default timeout of 600s. This should help avoid issues on GitHub actions where these timeout and cause build failures. The common case shouldn't really be affected. bazelbuild#17437
|
@susinmotion wdyt about us doing this, if we land here we can cherry pick to the 6.x branch before this is removed from bazel as well |
|
I think the change that just landed (causing those merge conflicts) allows it to be set by an env variable. Think that'll do the trick? |
|
yea probably fine, might still be nice to bump the default so folks don't have to do any work to get the fix, but we can roll with that for now. I submitted a cherry pick for that here #17521 |
|
Ah yeah that's a good thought re: default. That's fine with me. |
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
This should help avoid timeouts without users having to manually override this value. They can manually override it if they want to bring it down bazelbuild#17519 Closes bazelbuild#17522. PiperOrigin-RevId: 513258515 Change-Id: I2621b697643d4a1d6dc9db8ccee521f9ba0ce3dd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches all macOS toolchain setup compiles and executes to use the default timeout of 600s. This should help avoid issues on GitHub actions where these timeout and cause build failures. The common case shouldn't really be affected.
#17437